This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Streams 132#54
Merged
asfgit merged 8 commits intoapache:masterfrom Jul 21, 2014
robdouglas:STREAMS-132
Merged
Conversation
added 6 commits
June 23, 2014 14:03
Merge Apache
Merge From Apache
Merge Apache
Merge Apache
Merge Apache
…-null. Added debug logging statements to indicate when we hit a null content
Contributor
There was a problem hiding this comment.
What is the purpose for the try/catch/wrap? Are there new checked exceptions that you are wrapping?
Contributor
Author
There was a problem hiding this comment.
My thought here was to catch any exceptions at the processor level to try and help narrow down where the exception was thrown and what caused it. However, in https://github.com/apache/incubator-streams/pull/55 I catch any processor exceptions in the StreamsProcessorTask class, so this try/catch may be unnecessary now
Contributor
There was a problem hiding this comment.
especially since you are throwing a new exception
Contributor
Author
There was a problem hiding this comment.
Ok, it has been taken out
Contributor
Author
|
Responded to code review feedback |
Contributor
|
👍 |
asfgit
pushed a commit
that referenced
this pull request
Oct 1, 2014
STREAMS-176 | Added ability to override functions that could prove usefu...
steveblackmon
added a commit
that referenced
this pull request
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking content in getMatches to ensure that it is non-null. Added debug logging statements to indicate when we hit a null content